hush/cmd/hushd/metrics.go
jx12n 4d9a26498e hush: one-time secret links the server cannot read
Paste a secret, get a link, send it. The first person to open it and press
Reveal sees the secret; the link dies at that moment. The recipient needs a
browser and nothing else — no account, no client, no installed tooling.

The server cannot read what it stores. AES-256-GCM happens in the browser and
the key lives in the URL fragment, which browsers never transmit, so hushd
holds ciphertext and no key material. That is a property of where the key sits
rather than a promise about our conduct, which is why there is deliberately no
endpoint accepting a plaintext secret and no server-side-encryption fallback:
two guarantees behind one URL would be worse than one honest guarantee.

Three decisions carry the design:

  * GET /s/{id} touches NO storage, not even to check existence. Slack, Teams,
    WhatsApp, iMessage and Outlook Safe Links all fetch a URL before a human
    sees it, so destroying on GET would destroy most secrets in transit and the
    recipient's "already used" would be indistinguishable from interception.
    Only POST /reveal consumes. Bot user-agent detection is an arms race;
    removing the side effect from GET is not. Pinned by
    TestGettingTheRevealPageNeverConsumesTheSecret.
  * Destruction is one Redis GETDEL, which is atomic. GET-then-DEL has a window
    where two simultaneous readers both win, and for a one-time secret that
    window is the product. The store contract demands atomicity and the same
    concurrency test runs against both implementations.
  * Missing, already-revealed, expired and evicted are ONE indistinguishable
    410. Separating them would confirm to a prober that a given link was real.

The secret id IS the capability, so secret.ID is a struct whose every
accidental path — %v, %s, String(), slog, json.Marshal — emits a redacted
handle or refuses, and the raw value needs an explicit Value(). The first
version tried to prevent leaks by implementing no String() at all; its own test
caught that Go's fmt prints unexported fields anyway, so forbidding the method
had removed the control rather than the leak.

Operationally: structured JSON on stdout in the fleet's wire format, which
Vector already collects with no annotation; six hush_* metrics on the chassis
registry with no id, IP or path in any label; five alert rules wired into
vmalert. The public Ingress enumerates /, /s/ and /api/ so /metrics, /healthz
and /readyz share the port but are unreachable from the internet — no
basic-auth middleware to maintain and get wrong.

Dependencies are vendored because go-chassis is private: the Woodpecker test
step and the in-cluster Kaniko build both run -mod=vendor with GOPROXY=off and
hold no git credential.

cmd/hush-mcp is a stdio MCP server doing the same client-side crypto locally,
so using hush from an agent preserves the same guarantee as using it from a
browser.
2026-09-03 00:08:38 -06:00

85 lines
3.4 KiB
Go

package main
import "github.com/prometheus/client_golang/prometheus"
// Metrics are hush's own series, registered on the chassis's private registry
// via chassis.Config.Collectors so /metrics is one scrape.
//
// Cardinality rule applied throughout: NO label ever carries a secret id, a
// client IP, or a URL path. A metric label lands in the time series index and
// stays there, so a per-secret label would be both a capability leak and an
// unbounded index. Every label below is a closed enum.
type Metrics struct {
Created prometheus.Counter
Revealed *prometheus.CounterVec // result: ok | gone
Rejected *prometheus.CounterVec // reason: closed enum, see rejection reasons
Bytes prometheus.Histogram
StoreUp prometheus.Gauge
Limited prometheus.Counter
}
// Rejection reasons. A closed set, mirrored by the API error codes, so
// `hush_secrets_rejected_total{reason="ciphertext_too_large"}` and the 422 a
// caller saw are the same vocabulary.
const (
reasonTooLarge = "ciphertext_too_large"
reasonInvalid = "ciphertext_invalid"
reasonEmpty = "ciphertext_empty"
reasonTTL = "ttl_out_of_range"
reasonMalformed = "malformed_request"
)
func newMetrics() *Metrics {
return &Metrics{
Created: prometheus.NewCounter(prometheus.CounterOpts{
Name: "hush_secrets_created_total",
Help: "Secrets accepted and stored.",
}),
Revealed: prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "hush_secrets_revealed_total",
Help: "Reveal attempts by outcome. `gone` covers already-revealed, expired, never-existed and evicted, which the service does not distinguish.",
}, []string{"result"}),
Rejected: prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "hush_secrets_rejected_total",
Help: "Create attempts refused by validation, by reason.",
}, []string{"reason"}),
Bytes: prometheus.NewHistogram(prometheus.HistogramOpts{
Name: "hush_secret_ciphertext_bytes",
Help: "Size of stored ciphertext.",
// Hand-picked rather than DefBuckets (which tops out at 10): this
// measures bytes up to a 64 KiB cap, so the buckets straddle
// credential-sized (hundreds of bytes) through the limit.
Buckets: []float64{256, 1024, 4096, 16384, 65536},
}),
StoreUp: prometheus.NewGauge(prometheus.GaugeOpts{
Name: "hush_store_up",
Help: "1 when the last readiness probe reached Redis, 0 otherwise.",
}),
Limited: prometheus.NewCounter(prometheus.CounterOpts{
Name: "hush_rate_limited_total",
Help: "Requests refused by the create rate limit. A sustained rise is the abuse signal.",
}),
}
}
// Collectors is what gets handed to chassis.Config.Collectors. The chassis owns
// a private registry and exposes no accessor, so this slice is the only way
// hush's series reach /metrics.
func (m *Metrics) Collectors() []prometheus.Collector {
return []prometheus.Collector{m.Created, m.Revealed, m.Rejected, m.Bytes, m.StoreUp, m.Limited}
}
// Prime initialises the label combinations that alerting queries reference.
//
// Without this, `rate(hush_secrets_revealed_total{result="gone"}[15m])` returns
// no data until the first `gone` ever happens, and an alert written against a
// missing series is an alert that cannot fire. Priming makes the series exist
// at zero from boot.
func (m *Metrics) Prime() {
m.Revealed.WithLabelValues("ok")
m.Revealed.WithLabelValues("gone")
for _, r := range []string{reasonTooLarge, reasonInvalid, reasonEmpty, reasonTTL, reasonMalformed} {
m.Rejected.WithLabelValues(r)
}
}