jordan/rdev
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: clear stale error when dequeuing work tasks
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details

Browse Source 
When a task is retried (dequeued again after failure), the previous
error message was persisting in the work_queue table. This caused the
API to return confusing responses with status="running" but also
containing an error message from the previous attempt.

Now clears error and completed_at when claiming a task, matching the
fix already applied to build_audit.UpdateStatus.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
jordan 2026-02-07 08:51:34 -07:00
parent 9833725f31
commit 59aa173384
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/adapter/postgres/work_queue.go
View File

@ -60,9 +60,11 @@ func (r *WorkQueueRepository) Dequeue(ctx context.Context, workerID string) (*do
var resultJSON []byte var resultJSON []byte
var errorMsg sql.NullString var errorMsg sql.NullString
// Clear stale error/completed_at when claiming for execution or retry.
// This prevents the API from returning confusing "running" status with stale error messages.
err := r.db.QueryRowContext(ctx, ` err := r.db.QueryRowContext(ctx, `
UPDATE work_queue UPDATE work_queue
SET status = 'running', worker_id = $1, started_at = NOW() SET status = 'running', worker_id = $1, started_at = NOW(), error = NULL, completed_at = NULL
WHERE id = ( WHERE id = (
SELECT id FROM work_queue SELECT id FROM work_queue
WHERE status = 'pending' WHERE status = 'pending'