Implements horizontally-scalable worker pool architecture: - claudebox-sidecar: HTTP server for Claude Code, git, and SDLC ops - rdev-worker: standalone worker binary polling rdev-api for tasks - HTTP client adapter for sidecar communication - HPA with custom Prometheus metrics for autoscaling - ServiceMonitor for metrics scraping Code review fixes applied: - URL-encode query parameters in GitStatus (Critical #1) - Remove unused shellQuote function (Critical #2) - Use stdlib strings.Split/TrimSpace (Critical #3) - Add version injection via ldflags (Warning #4) - Add debug logging for swallowed git/sdlc errors (Warning #5, #6) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
288 lines
8.0 KiB
Go
288 lines
8.0 KiB
Go
package claudebox
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"log/slog"
|
|
"os/exec"
|
|
"strings"
|
|
)
|
|
|
|
// GitOperations provides local git operations in the container.
|
|
type GitOperations struct {
|
|
workDir string
|
|
giteaToken string
|
|
gitUser string
|
|
gitEmail string
|
|
logger *slog.Logger
|
|
}
|
|
|
|
// GitOperationsConfig holds configuration for git operations.
|
|
type GitOperationsConfig struct {
|
|
// WorkDir is the default working directory.
|
|
WorkDir string
|
|
|
|
// GiteaToken is the token for HTTPS push authentication.
|
|
GiteaToken string
|
|
|
|
// GitUser is the git commit author name.
|
|
GitUser string
|
|
|
|
// GitEmail is the git commit author email.
|
|
GitEmail string
|
|
|
|
// Logger is an optional logger for debug output.
|
|
Logger *slog.Logger
|
|
}
|
|
|
|
// NewGitOperations creates a new git operations helper.
|
|
func NewGitOperations(cfg GitOperationsConfig) *GitOperations {
|
|
if cfg.GitUser == "" {
|
|
cfg.GitUser = "rdev-worker"
|
|
}
|
|
if cfg.GitEmail == "" {
|
|
cfg.GitEmail = "worker@threesix.ai"
|
|
}
|
|
logger := cfg.Logger
|
|
if logger == nil {
|
|
logger = slog.Default()
|
|
}
|
|
return &GitOperations{
|
|
workDir: cfg.WorkDir,
|
|
giteaToken: cfg.GiteaToken,
|
|
gitUser: cfg.GitUser,
|
|
gitEmail: cfg.GitEmail,
|
|
logger: logger,
|
|
}
|
|
}
|
|
|
|
// CloneResult contains the result of a git clone operation.
|
|
type CloneResult struct {
|
|
Cloned bool // True if repo was cloned, false if already existed
|
|
Error error
|
|
}
|
|
|
|
// CloneRepo clones a git repository into the workspace if it doesn't exist.
|
|
// If the workspace already contains a git repo, it pulls the latest changes.
|
|
func (g *GitOperations) CloneRepo(ctx context.Context, workDir, cloneURL string) *CloneResult {
|
|
result := &CloneResult{}
|
|
|
|
if cloneURL == "" {
|
|
result.Error = fmt.Errorf("git clone URL is required")
|
|
return result
|
|
}
|
|
|
|
// Check if already a git repo with the correct remote
|
|
if g.isGitRepo(ctx, workDir) {
|
|
currentRemote, err := g.runGitOutput(ctx, workDir, "config", "--get", "remote.origin.url")
|
|
currentRemote = strings.TrimSpace(currentRemote)
|
|
|
|
if err == nil && currentRemote == cloneURL {
|
|
// Pull latest changes
|
|
if err := g.runGit(ctx, workDir, "pull", "--ff-only"); err != nil {
|
|
// Pull failed but repo exists - continue with existing state
|
|
g.logger.Debug("git pull failed, continuing with existing state", "error", err, "work_dir", workDir)
|
|
}
|
|
return result
|
|
}
|
|
|
|
// Different remote - clear and re-clone
|
|
if err := g.clearDir(ctx, workDir); err != nil {
|
|
result.Error = fmt.Errorf("clear workspace: %w", err)
|
|
return result
|
|
}
|
|
}
|
|
|
|
// Inject token for authentication
|
|
authCloneURL := cloneURL
|
|
if g.giteaToken != "" {
|
|
authCloneURL = strings.Replace(cloneURL, "https://", "https://token:"+g.giteaToken+"@", 1)
|
|
}
|
|
|
|
// Clone the repository
|
|
cmd := exec.CommandContext(ctx, "git", "clone", authCloneURL, workDir)
|
|
var stderr bytes.Buffer
|
|
cmd.Stderr = &stderr
|
|
|
|
if err := cmd.Run(); err != nil {
|
|
errMsg := g.redactToken(stderr.String())
|
|
result.Error = fmt.Errorf("git clone failed: %s: %s", err, errMsg)
|
|
return result
|
|
}
|
|
|
|
result.Cloned = true
|
|
return result
|
|
}
|
|
|
|
// CommitAndPushResult contains the result of commit and push operations.
|
|
type CommitAndPushResult struct {
|
|
HasChanges bool
|
|
CommitSHA string
|
|
FilesChanged []string
|
|
Pushed bool
|
|
Error error
|
|
}
|
|
|
|
// CommitAndPush commits and optionally pushes changes.
|
|
func (g *GitOperations) CommitAndPush(ctx context.Context, workDir, message string, push bool) *CommitAndPushResult {
|
|
result := &CommitAndPushResult{}
|
|
|
|
// Configure git user
|
|
if err := g.runGit(ctx, workDir, "config", "user.name", g.gitUser); err != nil {
|
|
result.Error = fmt.Errorf("git config user.name: %w", err)
|
|
return result
|
|
}
|
|
if err := g.runGit(ctx, workDir, "config", "user.email", g.gitEmail); err != nil {
|
|
result.Error = fmt.Errorf("git config user.email: %w", err)
|
|
return result
|
|
}
|
|
|
|
// Check for changes
|
|
status, err := g.runGitOutput(ctx, workDir, "status", "--porcelain")
|
|
if err != nil {
|
|
result.Error = fmt.Errorf("git status: %w", err)
|
|
return result
|
|
}
|
|
if strings.TrimSpace(status) == "" {
|
|
return result // No changes
|
|
}
|
|
result.HasChanges = true
|
|
|
|
// Stage all changes
|
|
if err := g.runGit(ctx, workDir, "add", "-A"); err != nil {
|
|
result.Error = fmt.Errorf("git add: %w", err)
|
|
return result
|
|
}
|
|
|
|
// Get list of staged files
|
|
diffOutput, err := g.runGitOutput(ctx, workDir, "diff", "--cached", "--name-only")
|
|
if err != nil {
|
|
result.Error = fmt.Errorf("git diff: %w", err)
|
|
return result
|
|
}
|
|
for _, f := range strings.Split(strings.TrimSpace(diffOutput), "\n") {
|
|
if f != "" {
|
|
result.FilesChanged = append(result.FilesChanged, f)
|
|
}
|
|
}
|
|
|
|
// Commit
|
|
if err := g.runGit(ctx, workDir, "commit", "-m", message); err != nil {
|
|
result.Error = fmt.Errorf("git commit: %w", err)
|
|
return result
|
|
}
|
|
|
|
// Get commit SHA
|
|
sha, err := g.runGitOutput(ctx, workDir, "rev-parse", "HEAD")
|
|
if err != nil {
|
|
result.Error = fmt.Errorf("git rev-parse: %w", err)
|
|
return result
|
|
}
|
|
result.CommitSHA = strings.TrimSpace(sha)
|
|
|
|
// Push if requested
|
|
if push {
|
|
// Configure credential helper
|
|
if g.giteaToken != "" {
|
|
credHelper := fmt.Sprintf("!f() { echo username=token; echo password=%s; }; f", g.giteaToken)
|
|
if err := g.runGit(ctx, workDir, "config", "credential.helper", credHelper); err != nil {
|
|
g.logger.Debug("credential helper config failed, continuing with push", "error", err)
|
|
}
|
|
}
|
|
|
|
if err := g.runGit(ctx, workDir, "push", "origin", "HEAD"); err != nil {
|
|
result.Error = fmt.Errorf("git push: %w", err)
|
|
return result
|
|
}
|
|
result.Pushed = true
|
|
}
|
|
|
|
return result
|
|
}
|
|
|
|
// GitStatusResult contains git status information.
|
|
type GitStatusResult struct {
|
|
IsRepo bool `json:"is_repo"`
|
|
HasChanges bool `json:"has_changes"`
|
|
ChangedFiles []string `json:"changed_files,omitempty"`
|
|
Branch string `json:"branch,omitempty"`
|
|
}
|
|
|
|
// Status returns the git status of the workspace.
|
|
func (g *GitOperations) Status(ctx context.Context, workDir string) (*GitStatusResult, error) {
|
|
result := &GitStatusResult{}
|
|
|
|
if !g.isGitRepo(ctx, workDir) {
|
|
return result, nil
|
|
}
|
|
result.IsRepo = true
|
|
|
|
// Get current branch
|
|
branch, err := g.runGitOutput(ctx, workDir, "rev-parse", "--abbrev-ref", "HEAD")
|
|
if err == nil {
|
|
result.Branch = strings.TrimSpace(branch)
|
|
}
|
|
|
|
// Get status
|
|
status, err := g.runGitOutput(ctx, workDir, "status", "--porcelain")
|
|
if err != nil {
|
|
return result, fmt.Errorf("git status: %w", err)
|
|
}
|
|
|
|
lines := strings.Split(strings.TrimSpace(status), "\n")
|
|
for _, line := range lines {
|
|
if len(line) > 3 {
|
|
result.ChangedFiles = append(result.ChangedFiles, strings.TrimSpace(line[3:]))
|
|
}
|
|
}
|
|
result.HasChanges = len(result.ChangedFiles) > 0
|
|
|
|
return result, nil
|
|
}
|
|
|
|
// isGitRepo checks if the directory is a git repository.
|
|
func (g *GitOperations) isGitRepo(ctx context.Context, workDir string) bool {
|
|
cmd := exec.CommandContext(ctx, "test", "-d", workDir+"/.git")
|
|
return cmd.Run() == nil
|
|
}
|
|
|
|
// clearDir clears the contents of a directory.
|
|
func (g *GitOperations) clearDir(ctx context.Context, dir string) error {
|
|
cmd := exec.CommandContext(ctx, "sh", "-c", fmt.Sprintf("rm -rf %s/* %s/.[!.]*", dir, dir))
|
|
return cmd.Run()
|
|
}
|
|
|
|
// runGit executes a git command.
|
|
func (g *GitOperations) runGit(ctx context.Context, workDir string, args ...string) error {
|
|
cmd := exec.CommandContext(ctx, "git", append([]string{"-C", workDir}, args...)...)
|
|
var stderr bytes.Buffer
|
|
cmd.Stderr = &stderr
|
|
if err := cmd.Run(); err != nil {
|
|
errMsg := g.redactToken(stderr.String())
|
|
return fmt.Errorf("%s: %s", err, errMsg)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// runGitOutput executes a git command and returns stdout.
|
|
func (g *GitOperations) runGitOutput(ctx context.Context, workDir string, args ...string) (string, error) {
|
|
cmd := exec.CommandContext(ctx, "git", append([]string{"-C", workDir}, args...)...)
|
|
var stdout, stderr bytes.Buffer
|
|
cmd.Stdout = &stdout
|
|
cmd.Stderr = &stderr
|
|
if err := cmd.Run(); err != nil {
|
|
errMsg := g.redactToken(stderr.String())
|
|
return "", fmt.Errorf("%s: %s", err, errMsg)
|
|
}
|
|
return stdout.String(), nil
|
|
}
|
|
|
|
// redactToken removes the Gitea token from output.
|
|
func (g *GitOperations) redactToken(s string) string {
|
|
if g.giteaToken == "" {
|
|
return s
|
|
}
|
|
return strings.ReplaceAll(s, g.giteaToken, "[REDACTED]")
|
|
}
|