Critical fix: WorkersHandler was missing workService dependency, causing 500 errors when workers tried to fail tasks. This caused tasks to get stuck in "running" state permanently. Also adds: - /work/tasks endpoint for debugging all tasks across projects - List method to WorkQueue interface for admin views - HTTP client tests for api_client.go and claudebox/client.go (48 tests) - Split work.go DTOs into work_dto.go to stay under 500 lines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
64 lines
2.9 KiB
Go
64 lines
2.9 KiB
Go
// Package port defines interfaces (ports) for external dependencies.
|
|
package port
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/orchard9/rdev/internal/domain"
|
|
)
|
|
|
|
// WorkQueue defines operations for the worker pool task queue.
|
|
// Unlike CommandQueue (project-specific claudebox commands), WorkQueue
|
|
// supports generic tasks that any worker in the pool can claim and execute.
|
|
type WorkQueue interface {
|
|
// Enqueue adds a task to the queue.
|
|
// Returns the task ID.
|
|
Enqueue(ctx context.Context, task *domain.WorkTask) (string, error)
|
|
|
|
// Dequeue atomically claims the next available task for a worker.
|
|
// Uses FOR UPDATE SKIP LOCKED for concurrent worker safety.
|
|
// Returns nil if no tasks are available.
|
|
Dequeue(ctx context.Context, workerID string) (*domain.WorkTask, error)
|
|
|
|
// Complete marks a task as successfully completed with results.
|
|
Complete(ctx context.Context, taskID string, result *domain.WorkResult) error
|
|
|
|
// Fail marks a task as failed with an error message.
|
|
// If retry_count < max_retries, the task will be re-queued as pending.
|
|
Fail(ctx context.Context, taskID string, errMsg string) error
|
|
|
|
// FailWithCode marks a task as failed with an error message and categorized error code.
|
|
// The error code enables clients to distinguish failure types (rate limit, auth, timeout).
|
|
// If retry_count < max_retries, the task will be re-queued as pending (error_code cleared).
|
|
FailWithCode(ctx context.Context, taskID string, errMsg string, code domain.WorkErrorCode) error
|
|
|
|
// Cancel marks a pending task as cancelled.
|
|
// Returns an error if the task is not in pending status.
|
|
Cancel(ctx context.Context, taskID string) error
|
|
|
|
// GetTask retrieves a task by ID.
|
|
GetTask(ctx context.Context, taskID string) (*domain.WorkTask, error)
|
|
|
|
// List returns all tasks with optional status filter and pagination.
|
|
// Use for admin/debugging views across all projects.
|
|
List(ctx context.Context, status *domain.WorkTaskStatus, opts domain.WorkListOptions) (*domain.WorkListResult, error)
|
|
|
|
// ListByProject returns tasks for a project with optional status filter and pagination.
|
|
ListByProject(ctx context.Context, projectID string, status *domain.WorkTaskStatus, opts domain.WorkListOptions) (*domain.WorkListResult, error)
|
|
|
|
// GetStats returns queue statistics.
|
|
GetStats(ctx context.Context) (*domain.WorkQueueStats, error)
|
|
|
|
// CleanupOld removes completed/failed/cancelled tasks older than the specified duration.
|
|
CleanupOld(ctx context.Context, olderThan time.Duration) (int64, error)
|
|
|
|
// RequeueStale re-queues tasks that have been running longer than the timeout.
|
|
// This handles workers that crashed without reporting completion.
|
|
RequeueStale(ctx context.Context, timeout time.Duration) (int64, error)
|
|
|
|
// RequeueStaleWithIDs re-queues stale tasks and returns their IDs.
|
|
// Used when callers need to sync external state (e.g., build audit).
|
|
RequeueStaleWithIDs(ctx context.Context, timeout time.Duration) ([]string, error)
|
|
}
|