task: aphoria-code-patterns
created: 2026-02-06
phase: COMPLETE
patterns:
  - name: unwrap-expect-isolation
    description: Test code uses unwrap/expect without #[allow] markers
    before_count: 72
    current_count: 0
    status: NOT_APPLICABLE
    note: All 72 unwrap() calls are in test functions - acceptable practice
  - name: json-construction-consistency
    description: Mix of json! macro and struct serialization
    before_count: 27
    current_count: 27
    status: NOT_APPLICABLE
    note: json! macro is used appropriately for dynamic JSON, SARIF format, and test fixtures
resolution: |
  Both patterns from the audit were false positives:
  1. Unwrap/expect: All in test code where it's acceptable
  2. JSON construction: json! macro is the right choice for dynamic/report JSON
  No fixes needed. Original audit was overly aggressive.
