From 5d211abce0e90d53bd76a66f8719cbfdd37fc9e4 Mon Sep 17 00:00:00 2001 From: jx12n Date: Mon, 8 Jun 2026 22:53:09 -0600 Subject: [PATCH] docs: record post-remediation re-review fixes in seven-dimension review Document the six issues a follow-up adversarial sweep surfaced in the M0-M10 remediation diff and their fixes (code already landed): - BLOCKER warm-tier double-count was a half-fix (read side only); now bounded on read + write (hour_agg anchored at last_min) + day tier. - CRITICAL W22 stale-index scrub now wired into the item overwrite path. - CRITICAL checkpoint read() made side-effect-free; temp-sweep moved to the writable recover() path. - WARNING W13 partition_id wired at construction; W22-class social-graph /collection u32 truncation routed through checked entity_as_u32. Updates the green-state line (1672 lib tests, clippy -D on all crates). --- docs/reviews/M0-M10-seven-dimension-review.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reviews/M0-M10-seven-dimension-review.md b/docs/reviews/M0-M10-seven-dimension-review.md index 94db15c..f1fd994 100644 --- a/docs/reviews/M0-M10-seven-dimension-review.md +++ b/docs/reviews/M0-M10-seven-dimension-review.md @@ -8,7 +8,7 @@ ## Remediation status (implemented) -All findings below have been remediated. Workspace is green: `cargo clippy -p tidaldb -D warnings` (and on `tidal-net`/`tidal-server`/`tidalctl`) clean, `cargo build --workspace --all-targets` clean, `cargo fmt` applied, `scripts/check-docs.sh` OK; engine lib 1663 tests / 0 failures (deterministic), engine integration + sibling suites green. ~160 regression tests were added. +All findings below have been remediated (see the post-remediation re-review section after this list for six further fixes a later adversarial pass surfaced). Workspace is green: `cargo clippy -D warnings` on all four crates (incl. `tidaldb --features metrics`) clean, `cargo build --workspace --all-targets` clean, `cargo fmt` applied, `scripts/check-docs.sh` OK; engine lib 1672 tests / 0 failures (deterministic), engine integration + sibling suites green. ~170 regression tests were added. - **Both BLOCKERs and all nine CRITICALs** are fixed with dedicated regression tests. - The BLOCKER #1 fix is read-side (`30d = last-7d hour tier + day buckets older than 7 days`); the report's suggested "clear the hour buckets on day rotation" would break the 7-day window (which legitimately reads all 168 hour buckets), so the read-side approach was used instead.