d69da6d627
Major changes: - Add internal/logging package with field constants, context propagation, sensitive data auto-redaction, and per-component log levels - Add worker timeout constants (TimeoutQuickOp, TimeoutHealthCheck, etc.) - Extend SDLC with callback handlers, generate endpoints, and executor - Add new cookbook trees for aeries and slackpath progression - Add skeleton templates for queue, realtime, and microservices - Add worker component template with async job processing - Refactor services and handlers to use new logging infrastructure - Split component.go into component_infra.go and component_listing.go Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
140 lines
5.3 KiB
Markdown
140 lines
5.3 KiB
Markdown
# Simple Prototype - Priority Implementation Index
|
|
|
|
## Overview
|
|
|
|
This directory contains implementation plans for fixing issues identified in the agent generation prototype. Each document provides root cause analysis, implementation details, and acceptance criteria.
|
|
|
|
## Priority Breakdown
|
|
|
|
### P0 - Critical (Blocks Cleanup Work)
|
|
|
|
| Doc | Title | Effort | Status |
|
|
|-----|-------|--------|--------|
|
|
| [p-0-bulk-deletion-ui.md](p-0-bulk-deletion-ui.md) | Bulk Deletion UI | Small | Pending |
|
|
|
|
**Why P0**: Cannot efficiently clean up the 270+ flagged videos without bulk operations. Currently must delete one at a time.
|
|
|
|
---
|
|
|
|
### P1 - High Priority (Systemic Issues)
|
|
|
|
| Doc | Title | Effort | Agents Affected |
|
|
|-----|-------|--------|-----------------|
|
|
| [p-1-british-accent-fix.md](p-1-british-accent-fix.md) | British Accent Fix | Medium | 100+ |
|
|
| [p-1-video-image-consistency.md](p-1-video-image-consistency.md) | Video/Image Consistency | Medium-Large | 70+ |
|
|
| [p-1-weight-consistency.md](p-1-weight-consistency.md) | Weight Consistency | Medium | 4+ identified |
|
|
|
|
**Why P1**: These issues affect many agents systemically. Fixing the root cause prevents future occurrences and enables batch remediation.
|
|
|
|
---
|
|
|
|
### P2 - Medium Priority (Quality Improvements)
|
|
|
|
| Doc | Title | Effort | Notes |
|
|
|-----|-------|--------|-------|
|
|
| [p-2-anatomical-fixes.md](p-2-anatomical-fixes.md) | Anatomical Fixes | Medium | Knees, limbs, fingers |
|
|
| [p-2-clothing-consistency.md](p-2-clothing-consistency.md) | Clothing Consistency | Medium | Outfit variety, gender |
|
|
| [p-2-gender-appropriate-poses.md](p-2-gender-appropriate-poses.md) | Gender-Appropriate Poses | Small | Male poses |
|
|
| [p-2-ethnicity-defaults.md](p-2-ethnicity-defaults.md) | Ethnicity Defaults | Small | Distribution balance |
|
|
| [p-2-props-objects.md](p-2-props-objects.md) | Props & Objects | Small | Phones, text, boundaries |
|
|
| [p-2-prompt-interpretation.md](p-2-prompt-interpretation.md) | Prompt Interpretation | Medium | Goblincore, anime, etc. |
|
|
| [p-2-duplicate-detection.md](p-2-duplicate-detection.md) | Duplicate Detection | Small | Handle uniqueness |
|
|
|
|
**Why P2**: These are quality polish items. Important for production but not blocking immediate cleanup work.
|
|
|
|
---
|
|
|
|
### P3 - Lower Priority (Individual Fixes)
|
|
|
|
| Doc | Title | Effort | Notes |
|
|
|-----|-------|--------|-------|
|
|
| [p-3-agent-specific-fixes.md](p-3-agent-specific-fixes.md) | Agent-Specific Fixes | Variable | 15+ individual agents |
|
|
|
|
**Why P3**: One-off fixes that can be addressed after systemic issues are resolved.
|
|
|
|
---
|
|
|
|
## Implementation Order
|
|
|
|
### Phase 1: Enable Cleanup
|
|
1. **p-0-bulk-deletion-ui** - Unblocks all manual cleanup
|
|
|
|
### Phase 2: Fix Generation Pipeline
|
|
2. **p-1-british-accent-fix** - Most widespread video issue
|
|
3. **p-1-video-image-consistency** - Eye color, ethnicity, weight in videos
|
|
4. **p-1-weight-consistency** - Body consistency in images
|
|
|
|
### Phase 3: Quality Polish
|
|
5. **p-2-anatomical-fixes** - Prevent future artifacts
|
|
6. **p-2-clothing-consistency** - Better outfit variety
|
|
7. **p-2-gender-appropriate-poses** - Male persona quality
|
|
8. **p-2-prompt-interpretation** - Keyword handling
|
|
9. **p-2-ethnicity-defaults** - Balanced demographics
|
|
10. **p-2-props-objects** - Phone/text issues
|
|
11. **p-2-duplicate-detection** - Prevent future duplicates
|
|
|
|
### Phase 4: Remediation
|
|
12. **p-3-agent-specific-fixes** - Address individual agent issues
|
|
13. Manual video deletion (using bulk delete from Phase 1)
|
|
14. Regenerate videos for accent-affected agents
|
|
|
|
---
|
|
|
|
## Files Changed Summary
|
|
|
|
### Core Package Changes
|
|
|
|
| Package | Files | Changes |
|
|
|---------|-------|---------|
|
|
| `pkg/persona/` | voice_dna.go, body_types.go, clothing.go, image_matrix.go | Add constraints, gender filtering |
|
|
| `pkg/personagen/` | image_generator.go, video_generator.go, demographics.go | Prompt improvements, accent fix |
|
|
| `pkg/personagen/` | keyword_classifier.go (new) | Prompt interpretation |
|
|
|
|
### Prototype Changes
|
|
|
|
| File | Changes |
|
|
|------|---------|
|
|
| `tmp/simple-prototype/main.go` | Bulk delete, video delete, regeneration handlers |
|
|
| `tmp/simple-prototype/index.html` | Selection mode, fix panel, warnings |
|
|
|
|
---
|
|
|
|
## Testing Strategy
|
|
|
|
After each phase:
|
|
1. Generate 5 new test personas with varied descriptions
|
|
2. Verify fix addresses the specific issue
|
|
3. Check for regressions in other areas
|
|
4. Document any new issues discovered
|
|
|
|
---
|
|
|
|
## Video Deletion Backlog
|
|
|
|
After P0 (bulk delete) is complete, these videos need deletion:
|
|
|
|
- **Male videos**: 98 agents
|
|
- **Female videos (various issues)**: 70 agents
|
|
- **Female videos (British accent)**: 100+ agents (may regenerate instead)
|
|
- **Age discrepancy videos**: 14 agents
|
|
|
|
Total: ~280 video deletions, potentially followed by regeneration for salvageable agents.
|
|
|
|
---
|
|
|
|
## Quick Reference: Issue → Document
|
|
|
|
| If you see... | Check... |
|
|
|---------------|----------|
|
|
| British accent in video | p-1-british-accent-fix |
|
|
| Wrong eye color in video | p-1-video-image-consistency |
|
|
| Weight varies across photos | p-1-weight-consistency |
|
|
| Malformed knee/limb | p-2-anatomical-fixes |
|
|
| Same outfit in all photos | p-2-clothing-consistency |
|
|
| Feminine pose on male | p-2-gender-appropriate-poses |
|
|
| "Goblincore" literal interpretation | p-2-prompt-interpretation |
|
|
| Duplicate agent names | p-2-duplicate-detection |
|
|
| Celebrity lookalike | p-2-ethnicity-defaults |
|
|
| Phone facing wrong way | p-2-props-objects |
|
|
| Individual agent issue | p-3-agent-specific-fixes |
|