stemedb/applications/aphoria/dogfood/msgqueue/FIXES-APPLIED.md

# Fixes Applied to msgqueue Dogfood Setup

**Date:** 2026-02-10
**Status:** ✅ Fixed and Validated

---

## Critical Fix #1: Invalid Comparison Modes

### Problem
Template used invalid comparison modes that don't exist in Aphoria's ComparisonMode enum:
- ❌ `greater_than`
- ❌ `less_than_or_equal`
- ❌ `in_range`

**Error message:**
```
unknown variant `greater_than`, expected one of `equals`, `not_equals`, `present`, `absent`, `contains`, `not_contains`
```

### Root Cause
When creating the template, I incorrectly assumed Aphoria supported numeric comparison operators. The actual schema only supports:
- ✅ `equals`
- ✅ `not_equals`
- ✅ `present`
- ✅ `absent`
- ✅ `contains`
- ✅ `not_contains`

### Solution
Updated all 22 claims in `claims-template.toml` to use valid comparison modes:

**For "must not be zero" constraints:**
```toml
predicate = "zero"
value = 0
comparison = "not_equals"
```

**For "must be bounded" constraints:**
```toml
predicate = "bounded"
value = true
comparison = "equals"
```

**For "must be configured" constraints:**
```toml
predicate = "configured"
value = true
comparison = "equals"
```

**For specific version requirements:**
```toml
predicate = "version"
value = "1.2"
comparison = "equals"
```

### Validation
```bash
$ aphoria claims import claims-template.toml --validate-only
✓ Validation passed
  Total claims: 22
  Warnings: 0

File is ready for import.
```

---

## Other Issues Fixed

### Fix #2: Missing .aphoria Directory
- **Problem:** `.aphoria/` directory didn't exist
- **Solution:** Created with empty `claims.toml` file

### Fix #3: Updated Skill Documentation
- **Problem:** Global skill at `.claude/skills/aphoria-dogfood/SKILL.md` had old shell script references
- **Solution:** Already updated via `sed` to use `claims-template.toml`

---

## Validation Results

### ✅ Template Validates
```bash
aphoria claims import claims-template.toml --validate-only
# ✓ Validation passed - Total claims: 22
```

### ✅ Directory Structure Complete
```
msgqueue/
├── .aphoria/
│   ├── claims.toml        # Empty, ready for import
│   └── config.toml        # Valid configuration
├── claims-template.toml   # Fixed with valid comparison modes
├── docs/sources/          # Authority source templates
├── plan.md               # 5-day workflow
├── README.md             # Getting started guide
└── SETUP-NOTES.md        # Migration notes
```

### ✅ No Invalid Comparison Modes
```bash
$ grep -r "greater_than\|less_than\|in_range" msgqueue/
# (no matches in active files)
```

---

## What Was Wrong vs What's Correct

### ❌ WRONG (before fix):
```toml
[[claim]]
predicate = "value_gt"
value = 0
comparison = "greater_than"  # INVALID
```

### ✅ CORRECT (after fix):
```toml
[[claim]]
predicate = "zero"
value = 0
comparison = "not_equals"  # VALID
```

---

## Remaining Known Issues

### 1. dbpool Dogfood
- **Location:** `applications/aphoria/dogfood/dbpool/plan.md`
- **Issue:** May contain invalid comparison mode examples in documentation
- **Impact:** Documentation only, not breaking
- **Action:** Low priority - fix when updating dbpool

### 2. httpclient Dogfood
- **Location:** Various summary docs
- **Issue:** References old `create-claims.sh` pattern
- **Impact:** Historical documentation only
- **Action:** None needed - these are completed exercise reports

---

## Testing the Fix

### Day 1 Workflow (Now Works):
```bash
cd applications/aphoria/dogfood/msgqueue

# Preview import
aphoria claims import claims-template.toml --dry-run

# Import all 22 claims
aphoria claims import claims-template.toml

# Verify
cat .aphoria/claims.toml  # Should show 22 claims
```

**Expected output:**
- ✓ 22 claims imported successfully
- ✓ 11 reused from httpclient/dbpool corpus (50%)
- ✓ 11 new for message queue domain

---

## Lessons Learned

1. **Always validate against actual schema** - Don't assume comparison operators exist
2. **Test template before documenting** - Run `--validate-only` before creating exercise
3. **ComparisonMode is limited** - Numeric constraints must be encoded in predicates, not comparison operators
4. **Predicate design matters** - Use `predicate = "zero"` + `not_equals` rather than `predicate = "value"` + `greater_than`

---

## Summary

**What was broken:** Invalid comparison modes in all 22 claims
**What's fixed:** Valid comparison modes using `equals`/`not_equals`/`present`/`absent`
**Validation status:** ✅ Template passes `--validate-only`
**Ready for use:** ✅ Yes - users can now run Day 1 successfully

**The msgqueue dogfood exercise is now ready to run.**