jordan/tidaldb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8f9aad1fe0
tidaldb/docs/planning/milestone-6/phase-4.md
jordan fe8d0c87e7 harden: restore CI verification, remove four wire-level fabrications, instrument the 401 path 
Implements tmp/tidaldb-fleet-hardening (20 planned tasks + 2 found by measurement).

Ring 0 — restore verification. .woodpecker.yaml step pods ran at the namespace
default of 1500m/2Gi, which OOMKilled a prior pipeline and starved the release
gate past its budget. Both push-path steps now declare
backend_options.kubernetes.resources as two YAML anchors declared once on their
first consuming step. The values are CALIBRATED against measured free node
capacity, not against the LimitRange max: `requests: cpu 2` (this roadmap's
original figure) fits on NO node and would sit Pending forever, because
`ci-build-bounds` grants permission and the nodes supply capacity, and those are
not the same thing.

The `nightly` cron described in this file for 216 days was never created, so
tier-3 chaos, the fault classes, mTLS and the PITR test produced exactly zero
signal while reading like standing coverage. nightly-chaos and
nightly-security-ops now alias the anchors and have budgets matching the gate
(their 120/90 were TIGHTER on the same runner, so they would have failed
nightly for a budget reason, not a correctness one). nightly-soak is REMOVED,
not scheduled: it drives 1000 rps for 600s gating on p99 <= 250ms, and the best
node has 1700m free CPU, so it would fail on starvation rather than regression —
manufacturing a nightly false alarm. Its commands move verbatim to
docs/runbooks/nightly-soak.md.

Ring 1 — four fabrications removed from the wire.
- scatter_merge sorted and truncated without re-stamping rank, so /feed and
  /search returned 1,1,2 under full placement. Reuses merge_cross_shard's
  existing stamp; asserted on BOTH the multi-group merge path and the
  single-group [only] fast path that bypasses it.
- aggregate_region_row's None arm invented `applied_events: 0` plus a deficit
  derived from it. applied_events/lag_events are now Option<u64>, null on the
  wire. leader_last_seq was also unwrap_or(0), so a node that could not reach
  the LEADER computed 0 - applied = 0 for every region and reported a converged
  cluster it had never measured — a fabrication pointing the dangerous way.
- tidalctl inferred NO REPORT from `applied == 0 && lag > 0`. That heuristic was
  actively hiding the PVC-wipe shape: a measured zero with a real deficit
  rendered as "no report" instead of BEHIND. Now read off the wire; converged
  exits 0, partitioned still exits nonzero.
- /sharded/* answered 201/204 for single-copy writes with nothing anywhere
  saying so. Now requires `x-tidal-ack: local`, rejecting with 400 via the
  existing invalid_input path. Six call sites migrated, not the two this
  roadmap predicted — including docs/runbooks/cluster.md §16.3, which told
  operators to run a quorum-write probe via POST /sharded/items. That probe
  cannot verify quorum: the surface applies locally with no WAL append. It was
  used as the safety check between every step of a staged deploy earlier today.

Ring 2 — observability. JSON_LOGS was already implemented and the deployment
simply never asked for it; the StatefulSet now sets it, plus
TIDAL_SERVICE_NAME=tidaldb because enabling it silently renames the
VictoriaLogs `service` stream field and would have blinded every query keyed on
it. Adds tidaldb_usearch_replicated_vectors_total, incremented on BOTH the
origin (wal_blob_first -> Ok(Some)) and the follower apply path — counting only
the origin would mean each vector lands on exactly one node, replicas never
agree, and the alert built on it pages forever.

Found by measurement, not planned: the 401 path discarded every fact about
every rejection. Traefik has served 101,858 rejected requests to the public
ingress — 87.6% of all its traffic — with no record of who or why anywhere.
unauthorized_response now emits reason (missing_token vs invalid_token, the
distinction that separates a scanner from a rotation that missed a consumer)
and the forwarded client. The token is never logged.

Also: scripts/restore-fleet.sh --cluster started the soak monitor while
deliberately leaving its gate suspended, orphaning a watcher that has reported
"0/30 green nights" for 13 days. The pair now moves together. Doc-guard's
three-warning backlog is cleared with real backfill for M4/M6/M12.

Verified: fmt clean; clippy 5 crates 0 new warnings (74 vs 74 baseline,
counted in a detached worktree at HEAD); lib 2110 passed; cluster_sharding 5;
cluster_runbook 10; tidalctl 38; doc-guard 0 warnings. Playwright 32/34 with
the two remaining failures asserting the rank fix against the not-yet-rolled
image — they are the post-deploy proof.
2026-08-30 20:55:58 -06:00

2.3 KiB
Raw Blame History

m6p4 — User Collections + Watch History + Saved Searches (✅ COMPLETE 2026-02-23)

Phase spec and acceptance criteria: ROADMAP · Milestone 6 · Phase 4. Milestone index: README.md. Backfilled record.

What shipped

  1. Collections (tidal/src/entities/collection.rs, tidal/src/db/collections.rs). create_collection(owner, name, visibility) with Visibility::{Private, Shared, Public}, plus add_to_collection (idempotent), remove_from_collection, and list_collections. Membership is a RoaringBitmap per collection for O(1) checks, persisted to fjall.
  2. FilterExpr::InCollection (tidal/src/storage/indexes/filter/expr.rs, evaluated in filter/evaluator.rs) constrains candidates to a collection's bitmap.
  3. Watch history / in-progress. The in_progress user-state filter selects items with a partial-completion signal, closing the "continue watching" surface.
  4. Saved searches (tidal/src/session/saved_search.rs). save_search, list_saved_searches, retrieve_saved_search (re-executes with a created_after bound so a saved search behaves as a persistent feed), and delete_saved_search.
  5. Cross-session preference aggregation — closes an M4 deferral. On close_session, every entity that received a session signal has its stored content embedding blended into the user's global preference vector (tidal/src/db/sessions.rs:532-574). Entities without stored embeddings are skipped, and a dimension mismatch is logged at WARN rather than silently dropped, because a silent drop hides a schema/embedding mismatch that quietly degrades personalization. This is the M4 "Deferred to Later Milestones" item "session signal influence on global user preference vector", delivered here rather than deferred further.

Evidence

  • tidal/tests/m6p4_collections.rs — 10 #[test] functions, incl. persistence across restart.
  • tidal/tests/m6_crash_surfaces.rs, tidal/tests/m7_crash_m6.rs — collections and saved searches under crash injection.
  • tidal/tests/session_durability.rs — the session half of the aggregation path.

Note on the "< 10 ms in_collection at 100 items" criterion

Marked [x] with no recorded measurement. Functional behaviour is proven by m6p4_collections.rs; the latency figure is not evidenced.